• Tomasz Wiszkowski's avatar
    Move voice suggestions provider to native code. · e7685508
    Tomasz Wiszkowski authored
    This change enforces coherency between Java and Native
    AutocompleteResult in the situation where some of the suggestions
    originate from the voice input.
    
    This change solves the following issues:
    - GroupSuggestionsBySearchVsURL will include the voice suggestions,
    - Suggestions can be merged / deduplicated with existing entries
    - Voice Suggestions will not be listed below grouped entries
      (suggestions with header),
    - We are now able to properly report these suggestions to GWS,
    - We should see fewer reports in Omnibox.Android.InvalidMatch as
      Java entries will now have corresponding Native matches.
    
    Bug: 1151794
    Change-Id: I575670781e744f3ac832705c830f3e0e506a83ac
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568850
    Commit-Queue: Tomasz Wiszkowski <ender@google.com>
    Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
    Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#834980}
    e7685508
BUILD.gn 18.6 KB