GitLab

Why remove DoesSiteRequireDedicatedProcess
==========================================

This CL removes
ShellContentBrowserClient::DoesSiteRequireDedicatedProcess.  We plan
to remove 2 other overrides of this ContentBrowserClient method in
other CLs.  We want to remove this ContentBrowserClient method
altogether, because
1) it is currently the only reason
   SiteInstanceImpl::DetermineProcessLockURL needs to take
   BrowserContext* as an argument (and therefore is problematic on
   threads other than UI thread)
2) the method was initially introduced to support --isolate-extensions
   which has been obsolete since shipping --site-per-process in M67.


Removal mechanics
=================

It seems that NavigationControllerOopifBrowserTest test never relied
on switches::kIsolateSitesForTesting.  In particular, I can't find
any references to ".is" in
https://codereview.chromium.org/1505343002/patch/100001/110001

IsolateIcelandFrameTreeBrowserTest can switch from using
switches::kIsolateSitesForTesting to using switches::kIsolateOrigins.


Bug: 898281
Change-Id: Idc8e45361e791ff30b9391666c55cf10159e793a
Reviewed-on: https://chromium-review.googlesource.com/c/1307876
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605137}