• Peter Kasting's avatar
    Add TimeDelta::FromHz() and ToHz(). · e8833bea
    Peter Kasting authored
    These are common operations that aren't necessarily obvious when
    reading code, and it's easy to get them subtly wrong.
    
    Before:
    
      TimeDelta frame_time =
          TimeDelta::FromSeconds(1) / monitor_refresh_rate_;
      TimeDelta duration =
          TimeDelta::FromSeconds(frame_count) / monitor_refresh_rate_;
      double framerate = TimeDelta::FromSeconds(1) / vsync_frame_interval_;
      double bps = 8.0 / time_per_byte_.InSecondsF();
    
    After:
    
      TimeDelta frame_time = TimeDelta::FromHz(monitor_refresh_rate_);
      TimeDelta duration =
          frame_count * TimeDelta::FromHz(monitor_refresh_rate_);
      double framerate = vsync_frame_interval_.ToHz();
      double bps = time_per_byte_.ToHz() * 8;
    
    Bug: 1104532
    Change-Id: I0919738d841177c77294e8983256a0cd93c5338b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337596
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: default avatarYuri Wiitala <miu@chromium.org>
    Auto-Submit: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#797128}
    e8833bea
time_unittest.cc 80.3 KB