• Toni Barzic's avatar
    Delay OnAppListVisibilityChanged if home launcher is transitioning · e88f0124
    Toni Barzic authored
    When starting animation to target drag state when sliding app window
    into home screen, if target home visibility is shown,
    HomeLauncherGestureHandler will hide and minimize the dragged window,
    which might cause focus to move to app list, and app list visibility
    to get updated before home gesture launcher animation is finished.
    If the app list visibility is changed at this point, the observers
    (notably shelf layout manager) will still think that the home state is
    changing, and will update its state accordingly. The state would not
    get updated when the animation finishes, given that another
    AppListVisibilityChanged notification would be skipped after the
    animation state is updated.
    
    To avoid this, delay the AppListVisibiltiyChanged notification until
    the home launcher finishes the transition.
    
    BUG=1021253
    
    Change-Id: I65d06cb88fd7042ca8df0a1a84d24109ccaa0e80
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894750Reviewed-by: default avatarAlex Newcomer <newcomer@chromium.org>
    Reviewed-by: default avatarManu Cornet <manucornet@chromium.org>
    Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#714722}
    e88f0124
shelf_layout_manager_unittest.cc 200 KB