• Tony de Luna's avatar
    NetworkList: Refactor section headers · e918a7d9
    Tony de Luna authored
    Changes in this cl:
     * Split SectionHeaderRowView and subclasses to a new file.
     * Remove the concept of a "subtitle" in a section header.
     * MobileHeaderRowView no longer subscribes to network updates directly,
       toggle status is triggered by NetworkListView.
     * Display mobile status messages with similar logic as we display WiFi
       status messages.
     * Initializes section headers on NetworkListView constructor to
       simplify logic.
     * Removes unused headers.
    
    Current UI spec no longer has the concept of a "subtitle". It was
    confusing that mobile status messages were being shown as a
    "subtitle", while WiFi status messages are a label in NetworkListView.
    
    Mobile toggle state and status message logic is complex. Decided to make
    NetworkListView call MobileHeaderView to get the mobile status message.
    This way we can re-use existing subtitle selection logic.
    
    Change-Id: I46c99d01100db39cc4541910d3b19f670cd1fc50
    Reviewed-on: https://chromium-review.googlesource.com/c/1371902
    Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
    Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#615762}
    e918a7d9
BUILD.gn 94.6 KB