• lazyboy's avatar
    Remove Downcasting RVContextMenuBase in ContextMenuDeleagate implementations. · e934d06d
    lazyboy authored
    ContextMenuDelegate talks in RVCMBase. This is fine for
    ContextMenuDelegate::BuildMenu, but while showing it through
    ContextMenuDelegate::ShowMenu, each platform downcasts the
    RVCMBase to its own variant (RVCMViews, RVCMMac, RVCMImpl),
    this seems unnecessary since the showing functionality can be
    moved to RVContextMenuBase.
    This CL does that and adds a virtual Show() function on
    RVCMBase.
    
    BUG=397364
    Test=No visible change should occur.
    For reference, this CL is related to brining up right-click context menus
    in chrome.
    
    Review URL: https://codereview.chromium.org/678653003
    
    Cr-Commit-Position: refs/heads/master@{#301564}
    e934d06d
panel_extension_browsertest.cc 11.3 KB