-
weiliangc authored
This reverts commit dfd53f11. Reason for revert: GPU FYI Windows bots compile failure crbug.com/854442 Compile error: [40824/45748] LINK task_viewer.service.exe task_viewer.service.exe.pdb FAILED: task_viewer.service.exe task_viewer.service.exe.pdb C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./task_viewer.service.exe /PDB:./task_viewer.service.exe.pdb @./task_viewer.service.exe.rsp C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??0InitParams@AuraInit@views@@QEAA@XZ >>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ) C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??1InitParams@AuraInit@views@@QEAA@XZ >>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ) Original change's description: > Add InitParams for views::AuraInit > > It's up to 7 parameters and I'm about to add an 8th. > > Bug: 851578 > Test: existing tests > Change-Id: I5dbfb98c90861a334ef9046cec4d69fb756879a1 > Reviewed-on: https://chromium-review.googlesource.com/1106431 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568594} TBR=jamescook@chromium.org,sky@chromium.org Change-Id: Iea7d59178394a95cbc6f419cd7079d00d66a8ac6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851578, 854442 Reviewed-on: https://chromium-review.googlesource.com/1107139Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568678}
e959c2d7