• Friedrich Horschig's avatar
    Reland "Render Tabs into Bottom sheet" · e95ccb91
    Friedrich Horschig authored
    This reverts commit 58e3dc5d.
    
    Reason for revert: The failed CrOS test doesn't seem affected
    by the newly introduced Android code. 
    
    Original change's description:
    > Revert "Render Tabs into Bottom sheet"
    > 
    > This reverts commit a4ae2e1f.
    > 
    > Reason for revert:
    > All/AutofillInteractiveIsolationTest.SimpleCrossSiteFill/1 started
    > to fail on ChromeOS likely after this change.
    > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/8133
    > https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5701
    > 
    > Original change's description:
    > > Render Tabs into Bottom sheet
    > > 
    > > This CL shapes the role of a KeyboardAccessoryData.Tab element:
    > > It is an element that provides a specific benefit to the Manual UI by...
    > > ... providing data that is used by the bar to render a tab (upcoming)
    > > ... providing the content for a separate tab in the bottom sheet.
    > > 
    > > This means, that the bottom sheet provides space for tabs and manages the
    > > general visibility and active states of tabs.
    > > The exact content of a tab doesn't matter to the AccessorySheetComponent.
    > > That way, it should become fairly straight forward to implement a new tab
    > > that is rendered into bottom sheet and accessory.
    > > 
    > > The first concrete instance of a bottom sheet will follow soon: a
    > > bottom sheet that contains password related actions and data.
    > > (It's important to not mix this specific data into the AccessorySheet
    > > component as other upcoming sheets are already planned, like one for
    > > payments and one for address data.)
    > > 
    > > Bug: 811747
    > > Change-Id: Id8bd8c389496246166d26a6c298056a142c36566
    > > Reviewed-on: https://chromium-review.googlesource.com/1047285
    > > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
    > > Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#559180}
    > 
    > TBR=bauerb@chromium.org,fhorschig@chromium.org
    > 
    > Change-Id: I879e4e89c674d47562c662b5c2bbac3487546062
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 811747
    > Reviewed-on: https://chromium-review.googlesource.com/1063732
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#559463}
    
    TBR=kinuko@chromium.org,bauerb@chromium.org,fhorschig@chromium.org
    
    Change-Id: I17ef937cfed19aa4b3fe9b10220b77ac349ffb31
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 811747
    Reviewed-on: https://chromium-review.googlesource.com/1063790Reviewed-by: default avatarFriedrich Horschig <fhorschig@chromium.org>
    Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559469}
    e95ccb91
java_sources.gni 169 KB