• Ian Kilpatrick's avatar
    [GridNG] Small fix to gap resolution, and abspos container. · e963a9ba
    Ian Kilpatrick authored
    Previously we'd just use the intrinsic block-size to resolve gaps, and
    abs-pos containing rects when we didn't know the block-size upfront.
    
    This was slightly incorrect as there might be a min/max size constraint
    growing or shrinking this final size.
    
    This patch moves the call to ComputeBlockSizeForFragment into
    PlaceItems. As a result of this there are a few small fixes:
    1) When we have an indefinite available-size, we resolve the grid-gap
       against zero. (This was surprising to me grid-gutters-{010,011} was
       testing this).
    2) Abspos "default" size is correctly calculated based on the final
       block-size (not intrinsic block-size).
    3) Resolving gaps against the "resolved" available block-size (not the
       intrinsic block-size). This correctly respects border/padding as
       well.
    
    Bug: 1045599
    Change-Id: I6be819b8eb254fe9e8eaee4d5a9caaa500a75601
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624032
    Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
    Reviewed-by: default avatarKurt Catti-Schmidt <kschmi@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#842748}
    e963a9ba
TestExpectations 494 KB