GitLab

g_metas_columns was defined in a header file. This means that every
translation unit that uses the array gets its own copy - in Windows
official builds this means that chrome.dll got two copies. Not a huge
deal (the actual string constants were probably shared), but worth
fixing. This change moves the array definition to a .cc file.

The reason these duplicate arrays don't cause linker errors is because
they are static, both from explicitly being tagged as such and because
const globals are implicitly static.

Change-Id: Id25f2a7fd27a4ffa3e292437892468346c2dc053
Reviewed-on: https://chromium-review.googlesource.com/571214
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Stanislav Chiknavaryan <stanisc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486899}