• Andrei Polushin's avatar
    Change type of ReplaceChars() parameter. · e9c90126
    Andrei Polushin authored
    Currently base::ReplaceChars() accepts std::string for the 3rd
    parameter, and immediately converts it to base::StringPiece.
    
    To avoid string copies on the caller side, it should accept
    base::StringPiece instead.
    
    This change became possible after r504430.
    
    BUG=760330
    TEST=base_unittests --gtest_filter=StringUtilTest.ReplaceChars
    
    Change-Id: I9a3a4cc02cfbfb8c8a258dc077612dd5146b9592
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930799
    Auto-Submit: Andrei Polushin <anpol@yandex-team.ru>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Commit-Queue: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#719410}
    e9c90126
string_util.cc 37.5 KB