• Ye Kuang's avatar
    Use luci-go isolate client in mb.py · e9cc819f
    Ye Kuang authored
    Because go's "check" subcommand doesn't generate isolated file, the '-s' flag is dropped. This is fine because Go isolate doesn't consume isolated file at all. More details in crbug.com/1059668.
    
    #Benchmark
    
    Benchmark is done using the "archive" subcommand. Note that the first invocation will upload to isolate-server, which we want to *exclude*. So the results were taken from the second invocation.
    
    ##blink_web_tests:
    
    * PY: 1m15s~1m40s (python tools/swarming_client/isolate.py archive -i out/Release/blink_web_tests.isolate -s out/Release/blink_web_tests.isolated -I https://isolateserver.appspot.com)
    * GO: ~8s (tools/luci-go/isolate archive -i out/Release/blink_web_tests.isolate -s out/Release/blink_web_tests.isolated -I https://isolateserver.appspot.com)
    
    ##browsers_tests:
    
    * PY: 31s
    * GO: 3s
    
    Bug: 1059167
    Change-Id: Idffb6c33e2482c2829f54c56e753623f26997a10
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094482
    Commit-Queue: Ye Kuang <yekuang@google.com>
    Reviewed-by: default avatarTakuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#749557}
    e9cc819f
mb_unittest.py 30.9 KB