GitLab

This reverts commit f6fa5cac.

Reason for revert: broke https://ci.chromium.org/p/chromium/builders/ci/ios-device/116376

Original change's description:
> Enable -Wextra-semi in release builds that don't set dcheck_always_on=true.
> 
> Most of these are macros that expand to nothing when dchecks are off, but
> to a declaration when dchecks are on. They are meant to be used to declare
> member variables.
> 
> Since clang-format gets very confused on class member declarations that
> don't end in a semicolon and since we require clang-formatting,
> we need some way to still permit a semicolon after these macros even
> with dchecks off. To that end, add a dummy static_assert() at the end
> of these macros.
> 
> Alternatively, we could surround all uses of these macros with explicit
> DCHECK_IS_ON() checks.
> 
> Depends on https://skia-review.googlesource.com/c/skia/+/196421
> 
> TBR=dalecurtis
> 
> Bug: 926235,936856
> Change-Id: I66ab08f383b2f27dc6a7617f67f33fa66ddfa00c
> Reviewed-on: https://chromium-review.googlesource.com/c/1495041
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636838}

TBR=dalecurtis@chromium.org,gab@chromium.org,thakis@chromium.org

Change-Id: Iba14b13129b16b569249e62afa4644209e1435c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 926235, 936856
Reviewed-on: https://chromium-review.googlesource.com/c/1496308Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636850}