• Jan Wilken Dörrie's avatar
    Revert "[media] Maintain DecoderSelector state throughout decoder selection." · ea29e693
    Jan Wilken Dörrie authored
    This reverts commit 9e96a32b.
    
    Reason for revert: Likely culprit of https://crbug.com/879469.
    
    Original change's description:
    > [media] Maintain DecoderSelector state throughout decoder selection.
    > 
    > This CL changes DecoderStream to maintain an instance of DecoderSelector
    > continually. This enabled DecoderSelector to maintain
    > DecryptingDemuxerStream state and the blacklist internally.
    > 
    > An immediate consequence is that DecoderSelector can now always try the
    > full list of potential decoders each time that selection is triggered.
    > This fixes the GPU->GPU changeType() transition, and provides a
    > foundation to build GPU fallforward on top of.
    > 
    > Another consequence is that fallback can occur more than once for a
    > stream. It is no longer possible to loop forever doing fallbacks, so this
    > is a robustness improvement in addition to being a requirement for
    > changeType().
    > 
    > Bug: 877673
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    > Change-Id: I76d1bed1c914e1ec58a6653d7200fbb67f70971a
    > Reviewed-on: https://chromium-review.googlesource.com/1188978
    > Commit-Queue: Dan Sanders <sandersd@chromium.org>
    > Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#587908}
    
    TBR=dalecurtis@chromium.org,xhwang@chromium.org,sandersd@chromium.org
    
    Change-Id: I6836b3e04b56591289fd973a5e89092b70e923fe
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 877673
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1199082Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#587959}
    ea29e693
test_helpers.cc 11.7 KB