• Bruce Dawson's avatar
    Prevent tail-call optimizations in thread watcher · ea5d856a
    Bruce Dawson authored
    thread_watcher_report_hang.cc has various unique functions which are
    designed to be on the call stack when hangs are reported. Guaranteeing
    this requires making all of the functions unique and inhibiting tail
    calls. The tail call inhibiting was only applied to two of the functions
    so this change applies it to the other two (commented out in one of
    them) and adds the NOT_TAIL_CALLED attribute to the function they all
    call. This attribute makes the ordering in the functions irrelevant but
    there is no cost to having belt and suspenders, so why not?
    
    This completes the work of crrev.com/c/1373878.
    
    Bug: 905288, 1032679
    Change-Id: I383cc3453ab2f506017de1143bc8f3666ed38a47
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443891Reviewed-by: default avatarJesse Doherty <jwd@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#813393}
    ea5d856a
thread_watcher_report_hang.cc 2.4 KB