• Marc Treib's avatar
    Sync DataTypeManagerImpl: Mark failed data types on Sync startup · eaa5ef4f
    Marc Treib authored
    This fixes a bug where Sync configuration would never finish:
    DataTypeManager is supposed to filter out failed data types before
    passing them to ModelAssociationManager. Before this CL, it failed to
    do that if a data type (in particular, the DataTypeController) was
    already in a FAILED state at Sync startup. In that case,
    ModelAssociationManager would forever wait for that type to start.
    This could happen if, after a data type error was encountered, Sync got
    stopped and restarted.
    
    Bug: 967344
    Change-Id: Ic3429ce4a056b5a505cc9bb1a2cc0c87e4d2ec5c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645231
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#666632}
    eaa5ef4f
model_association_manager.cc 19 KB