• Fabio Tirelo's avatar
    Reland "[PM] Add FrameNode viewport intersection" · eab74a79
    Fabio Tirelo authored
    This reverts commit 53d410bb.
    
    Reason for revert: There is a CL landed after this that changes a type somewhere, reverting is not that trivial
    
    Original change's description:
    > Revert "[PM] Add FrameNode viewport intersection"
    >
    > This reverts commit cf2a7489.
    >
    > Reason for revert:
    > FrameNodeImplBrowserTest.ViewportIntersection_PartiallyVisible failing on CrOS
    >  - example build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/41947
    >
    > TBR=pmonette@chromium.org
    >
    > Original change's description:
    > > [PM] Add FrameNode viewport intersection
    > >
    > > This CLs plumbs the viewport intersection to the FrameNode, which
    > > will allow the tracking of the visibility of each frame.
    > >
    > > Bug: 1077217
    > > Change-Id: Id2811b1c52e4fa3f3c449d1b32a1cb7084f82116
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399621
    > > Reviewed-by: François Doray <fdoray@chromium.org>
    > > Reviewed-by: danakj <danakj@chromium.org>
    > > Reviewed-by: Nasko Oskov <nasko@chromium.org>
    > > Reviewed-by: David Bokan <bokan@chromium.org>
    > > Commit-Queue: Patrick Monette <pmonette@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#816728}
    >
    > TBR=danakj@chromium.org,nasko@chromium.org,bokan@chromium.org,fdoray@chromium.org,pmonette@chromium.org
    >
    > Change-Id: I4e1cb014232b82016e14fbd85352a6442323300f
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1077217
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470463
    > Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#817024}
    
    TBR=danakj@chromium.org,nasko@chromium.org,fdoray@chromium.org,pmonette@chromium.org,ftirelo@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1077217
    Change-Id: I3c36272ac57b0857400331196a506069c596d36e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471259Reviewed-by: default avatarFabio Tirelo <ftirelo@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#817030}
    eab74a79
frame_node_impl.h 15.3 KB