• Jesse McKenna's avatar
    Check for GDI exhaustion if window creation fails · ead1e8ab
    Jesse McKenna authored
    This change makes gfx::CheckWindowCreated() check whether the system
    is out of Graphics Device Interface (GDI) resources if window creation
    fails. Exhaustion of GDI resources indicates a GDI leak, either by
    Chrome or by another program, caused by the acquisition of handles to
    many GDI objects without the release of those handles.
    
    Explicitly checking for this case will make it easier to diagnose
    crashes in gfx::CheckWindowCreated(), e.g., crbug.com/1091696, which
    is suspected to be GDI-leak-related but impossible to diagnose with
    certainty without understanding the GDI-object counts at the time of
    the crash.
    
    Bug: 1091696
    Change-Id: Ifaeceae8f7c511a9c7d0f80f37709fbc1c5bb9d8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244124
    Commit-Queue: Jesse McKenna <jessemckenna@google.com>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#782096}
    ead1e8ab
hwnd_util.cc 7.36 KB