• Greg Thompson's avatar
    Use the proper registry hive when accessing Chrome's ClientState key. · eae4f3c3
    Greg Thompson authored
    Google Update and Chrome use Chrome's ClientState key as a bucket for
    holding data and to communicate with one another. In general, HKLM is
    used for system-level installs and HKCU is used for per-user
    installs. GoogleUpdateSettings was looking in both hives for values,
    which can lead to incorrect values being used. This CL tightens up
    accesses so that only the correct hive is used for each value.
    
    This CL also updates some of the implementation to use install_static
    instead of BrowserDistribution, which is deprecated.
    
    Finally, some dead code has been removed.
    
    BUG=none
    R=rogerta@chromium.org
    
    Change-Id: I0d70042e2d70d9d33e9eb8c2f5e846e35d5d0634
    Reviewed-on: https://chromium-review.googlesource.com/1179743Reviewed-by: default avatarRoger Tawa <rogerta@chromium.org>
    Commit-Queue: Greg Thompson <grt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#584046}
    eae4f3c3
google_update_settings.h 15.5 KB