• edchin's avatar
    Reland "[ios] Hook up remote tabs in tab grid" · eaedf244
    edchin authored
    This reverts commit cd9fa081.
    
    This CL fixes the reason that the DCHECK failed causing
    the original revert.
    
    Original change's description:
    > Revert "[ios] Hook up remote tabs in tab grid"
    >
    > This reverts commit 5316b1cb.
    >
    > Reason for revert: breaking ios_chrome_settings_egtests
    >
    > Original change's description:
    > > [ios] Hook up remote tabs in tab grid
    > >
    > > This CL hooks up the remote tabs in the tab grid.
    > >
    > > A user can sign in from the remote tabs page in the tab grid. The
    > > transition animation that displays the signin interaction controller
    > > looks bad (and we are investigating the cause). If the user is signed
    > > in but does not have sync enabled, the user can enable sync from here.
    > >
    > > Currently, tapping on a tab does nothing. This will be enabled in a
    > > future CL.
    > >
    > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > > Change-Id: Ifba06919e1fb496917254a0da7e5462a4b854d79
    > > Reviewed-on: https://chromium-review.googlesource.com/1084080
    > > Commit-Queue: edchin <edchin@chromium.org>
    > > Reviewed-by: Eugene But <eugenebut@chromium.org>
    > > Reviewed-by: Sergio Collazos <sczs@chromium.org>
    > > Reviewed-by: edchin <edchin@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#564684}
    >
    > TBR=rohitrao@chromium.org,eugenebut@chromium.org,edchin@chromium.org,sczs@chromium.org,javierrobles@chromium.org
    >
    > Change-Id: Idc0b0b2def356a173949298bc7f560ee4dad3744
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Reviewed-on: https://chromium-review.googlesource.com/1088566
    > Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    > Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#564828}
    
    TBR=rohitrao@chromium.org,eugenebut@chromium.org,olivierrobin@chromium.org,edchin@chromium.org,sczs@chromium.org
    
    Change-Id: I34dca3dadbe0d356aff881559353876736722224
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1089251Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
    Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
    Reviewed-by: default avataredchin <edchin@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#565045}
    eaedf244
main_controller.mm 103 KB