• James Cook's avatar
    Reland: Let ash provide window show state if client has SHOW_STATE_DEFAULT · eb602d26
    James Cook authored
    For lock screen app windows the window manager needs to specify the
    initial show state of the window. Ensure the client (chrome) does not
    overwrite the aura window show-state property in ash if the client
    window has ui::SHOW_STATE_DEFAULT.
    
    Fixes LockScreenNoteTakingTest.Launch pass under SingleProcessMash
    
    The reland changes FirstAppRunToastManager to use a WidgetObserver
    to watch for app window bounds changes. Mash tears down aura::Windows
    similarly to aura on MS Windows and Linux. The aura::Window for
    the app window can be destroyed before AppWindowRegistry notifies
    StateController and FirstAppRunToastManager that the app has been
    closed, so it's not safe for FirstAppRunToastManager::Reset() to
    manipulate the aura::Window to remove the ScopedObserver. See bug.
    
    TBR=sky@chromium.org
    TBR=tsepez@chromium.org
    
    Bug: 899055
    Test: added to views_mus_unittests
    Change-Id: I886dbe45fe53708beb4441c1d9da2587a2352997
    Reviewed-on: https://chromium-review.googlesource.com/c/1312972Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Reviewed-by: default avatarToni Baržić <tbarzic@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#605110}
    eb602d26
desktop_window_tree_host_mus.cc 39.4 KB