• Francois Doray's avatar
    TaskScheduler: Do not limit the number of BLOCK_SHUTDOWN tasks posted during shutdown. · ebdf7bee
    Francois Doray authored
    There is currently a CHECK that no more than 1000 BLOCK_SHUTDOWN tasks
    are posted during shutdown. The goal of this CHECK is to prevent
    shutdown hangs caused by components that behave badly (e.g. a component
    that reposts a BLOCK_SHUTDOWN task at the end of each BLOCK_SHUTDOWN
    task).
    
    This CL removes this CHECK because:
    - It is redundant with the hang watcher.
    - Unlike the failures reported by the hang watcher, the failures
      reported by this CHECK aren't necessarily associated with user pain
      (e.g. posting more than 1000 very short BLOCK_SHUTDOWN tasks during
      shutdown will probably not be noticed by the user if it doesn't
      trigger the hang watcher).
    
    Bug: 897334
    Change-Id: I6c0ce508c5bd892724a92add3025afe9019a35e7
    Reviewed-on: https://chromium-review.googlesource.com/c/1318173Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#605461}
    ebdf7bee
task_tracker.cc 35.8 KB