• Rouslan Solomakhin's avatar
    [Render Frame Host] Document IsCurrent(). · ebf6103c
    Rouslan Solomakhin authored
    Before this patch, Chromium developers could call
    RenderFrameHost::IsCurrent() to check whether the frame is about to be
    deleted without understanding that IsCurrent() can return false
    temporarily, e.g., when in bfcache.
    
    This patch adds comments to RenderFrameHost::IsCurrent() and
    WebContents::FromRenderFrameHost() that explain how IsCurrent() should
    be called before FromRenderFrameHost().
    
    After this patch, it should be more clear to Chromium developers that
    IsCurrent() should be used to check whether FromRenderFrameHost() can be
    called.
    
    Change-Id: I7bba60ca7e73e3ff5c4320ffe8f3ee1be00393be
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461590
    Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
    Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
    Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#818694}
    ebf6103c
web_contents.h 51.2 KB