• Tim Schumann's avatar
    Revert "Tab Search: Update TabSearchButton tests" · ec14e7b7
    Tim Schumann authored
    This reverts commit 0d88901a.
    
    Reason for revert: Introduced a heap user after free in TabSearchButtonBrowserTest.TestBubbleVisible.
    
    [my hunch is, it's just missing a call to tab_search_button()->bubble_for_testing()->Close()]
    
    Original change's description:
    > Tab Search: Update TabSearchButton tests
    > 
    > This CL creates a new file for TabSearchButton browser tests. These
    > tests run for both the fixed and regular entrypoints.
    > 
    > Existing tests for the TabSearchButton have been moved from the tab
    > strip into the TabSearchButton browser tests.
    > 
    > Bug: 1099917
    > Change-Id: I0b1d57826768705316b9bed814dac7af96ce52e8
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422730
    > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#809376}
    
    TBR=sky@chromium.org,tluk@chromium.org
    
    Change-Id: I7b90eff0efbd7a807c0f085496f75139b1961909
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1099917,1131399
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424288Reviewed-by: default avatarTim Schumann <tschumann@chromium.org>
    Commit-Queue: Tim Schumann <tschumann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#809723}
    ec14e7b7
browser_view.cc 132 KB