• manuk's avatar
    [chrome://omnibox] Update result details for real omnibox inputs. · ec2c17d7
    manuk authored
    Above each response, the debugs page displays result details including:
    1) cursor position
    2) elapsed time
    3) all providers done
    4) host
    5) has isTypedHost
    These are updated when inputting into the HTML omnibox, but when inputting into
    the window omnibox, only (3) is updated correctly.
    
    This CL:
    1) Updates the 5 fields when inputting from the window omnibox.
    2) Adds 'input type' (e.g. URL).
    3) Wires in cursor position similar to the other 4 fields from the page handler
    and removes the hacked cursor position wired in from query inputs.
    4) Updates the label for (5) to 'is typed host'.
    5) Rearranges related variables to be consistent between files.
    
    Bug: 1011632
    Change-Id: I830b4af3d01d18faafbdaaeaea8614624a401c4c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846311Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
    Commit-Queue: manuk hovanesian <manukh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#704258}
    ec2c17d7
ui_test_utils.cc 22.4 KB