GitLab

There is no need to cast SyncableService instances to interface
SyncChangeProcessor, neither do these services need to implement any
functions in there, since they are not exercised.

One exception is SyncChangeProcessor::UpdateDataTypeContext(), which
is called from SharedChangeProcessor, but there is no SyncableService
that implements any functionality in such function.

In order to keep the patch less intrusive, GetAllSyncData() is kept
around, now moved to SyncableService, since all implementations provide
such functionality. However, we don't seem to call that function from
anywhere, so a TODO has been added to simplify that in future patches.

TBR=groby@chromium.org

Bug: 870624
Change-Id: I54b33cdd1ecc5584a806d3ff0fc0f3f6708467ca
Reviewed-on: https://chromium-review.googlesource.com/1243809Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594702}