• Tom Anderson's avatar
    [XProto] Fix GPU process crash when Xlib is not implicitly loaded · edec9c14
    Tom Anderson authored
    The old code used dlsym(RTLD_DEFAULT), which will attempt to obtain the
    symbol from libraries already loaded.  This works most of the time
    because Xlib gets loaded by eg. GTK, but in cases where Xlib is not
    already loaded (eg. certain ChromeOS setups), XFree will not be found,
    leading to a crash.  The fix is to switch to the existing xlib_support
    which internally does dlopen("libX11.so.6") so it shouldn't have this
    issue.
    
    R=sky
    
    Bug: 1150918
    Change-Id: I82d28cf86e187cc1213b607482f7bd1f4a8e2287
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552209
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#829901}
    edec9c14
xlib.h 505 Bytes