• Chris Thompson's avatar
    Address CertAndCTVerifier crash · ee104c44
    Chris Thompson authored
    This enforces the invariant that CertVerifyResult::verified_cert should
    always be non-null for the case when a MojoCertVerifier is disconnected,
    and also adds a check to CertAndCTVerifier to only perform CT
    verification if the underlying CertVerifier succeeded. This fixes a
    crash where the CT verification step would assume there was a cert in
    the CertVerifyResult, but MojoCertVerifier had been disconnected and
    reset the CertVerifyResult in its disconnect handler.
    
    Bug: 1153484
    Change-Id: I6039ea4e28715a5c6d5e9a2878c538ddf4d5aa8f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565537Reviewed-by: default avatarRyan Sleevi <rsleevi@chromium.org>
    Commit-Queue: Chris Thompson <cthomp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#832084}
    ee104c44
cert_and_ct_verifier.h 1.84 KB