• Thomas Guilbert's avatar
    [Sheriff] Revert "Fix Crash in Hung Pages view while in screen reader" · eece779c
    Thomas Guilbert authored
    This reverts commit fc8af8e6.
    
    Reason for revert: Crashing on MAC bots https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/5816
    
    Original change's description:
    > Fix Crash in Hung Pages view while in screen reader
    >
    > There seems to be a timing issue between the AX queries for
    > GetText and when the model is updating. Looking at the model
    > it seems not all TabDestroyed calls are informing the Observers
    > that the model has changed.
    >
    > The TableView uses Virtual AX Children that depends on the
    > observers to call. Moved the observer call from TabDestroyed to Reset
    > to handle all delegate_->TabDestroyed() calls defined below:
    >
    >  - RenderProcessExited
    >  - RenderWidgetHostDestroyed
    >  - TabDestroyed,
    >  - RenderViewHostChanged
    >  - WebContentsDestroyed
    >
    > Bug: 1140454
    > Change-Id: Ie7fd07d6540b9509b998d5cd95d1fd16f47f9018
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530295
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Commit-Queue: Mohamed Mansour <mmansour@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#827900}
    
    TBR=sky@chromium.org,tapted@chromium.org,robliao@chromium.org,dfried@chromium.org,mmansour@microsoft.com
    
    Change-Id: Ifb73fc1762d043fbba1d3a3a8b5744c169b9a88b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1140454
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543191Reviewed-by: default avatarThomas Guilbert <tguilbert@chromium.org>
    Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#827977}
    eece779c
hung_renderer_view.h 6.94 KB