• Lukasz Anforowicz's avatar
    Add extra logging and assertions to track flakiness of SavePage tests. · eed88ce8
    Lukasz Anforowicz authored
    This CL tries to track down the flakiness of the following tests:
    - SavePageOriginalVsSavedComparisonTest.ObjectElementsViaHttp
    - SavePageOriginalVsSavedComparisonTest.CrossSiteObject
    where the test will sometimes/flakily see that all the expected frames
    are present, but find-in-page will fail to find text that is expected to
    be found in one of the subframes.
    
    After this CL, we should be able to verify if the problematic subframe
    has finished loading - if it executed `window.name = ...` or not.
    
    Bug: 1070597, 1070886
    Change-Id: I7d499cbb228663b63030fac7dab37140b7c9be7f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510913Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#824222}
    eed88ce8
save_page_browsertest.cc 58.9 KB