• Maksim Moskvitin's avatar
    Revert "Keep DevTools navigator.language in-sync with chromiums app language" · ef121dab
    Maksim Moskvitin authored
    This reverts commit 73ac7d88.
    
    Reason for revert: new tests consistently crashes on Mac builders,
    see crbug.com/1126379.
    
    Original change's description:
    > Keep DevTools navigator.language in-sync with chromiums app language
    > 
    > DevTools is considered part of the Chromium UI, so it should be
    > displayed in the same language as the Chromium UI and not the configured
    > accepted language (chrome://settings/languages).
    > 
    > This CL moves the code where we override the DevTools renderer
    > preferences around so it works consistently across platforms. It also
    > installs an event handler in case the user changes his language settings
    > so `navigator.language` has consistently the same value in the
    > DevTools renderer.
    > 
    > R=​petermarshall@chromium.org
    > 
    > Bug: chromium:1125490
    > Change-Id: Iaac568d82357d6ae7c50d5022d687f4f1741b147
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398538
    > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#805219}
    
    TBR=caseq@chromium.org,petermarshall@chromium.org,szuend@chromium.org
    
    Change-Id: I5d80fbfce70fd62336b15beb0d29a7bbe09ba6fd
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:1125490, chromium:1126379
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400280Reviewed-by: default avatarMaksim Moskvitin <mmoskvitin@google.com>
    Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
    Cr-Commit-Position: refs/heads/master@{#805249}
    ef121dab
devtools_ui_bindings.cc 61.7 KB