• dpapad's avatar
    Settings: Change subpage help icon to a cr-icon-button. · ef899c98
    dpapad authored
    Previously it was implemented as an iron-icon-button + paper-ripple
    inside a <a> element, which was problematic (infinite ripples showing
    when holding down the enter key).
    
    By leveraging cr-icon-button the bug above is fixed. As a side effect
    the focus indicator changes from an outline to a ripple, which will
    change back once cr-icon-button itself will transition from ripples to
    outlines for focus (soon).
    
    Fixed: 1167155
    Change-Id: Ic899c251b3c56bf7b73fcde8682afa73b9918730
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644461
    Commit-Queue: John Lee <johntlee@chromium.org>
    Auto-Submit: dpapad <dpapad@chromium.org>
    Reviewed-by: default avatarJohn Lee <johntlee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#846224}
    ef899c98
settings_subpage.html 3.98 KB