• Dan McArdle's avatar
    Use ERR_NAME_NOT_RESOLVED for DNS responses to INTEGRITY queries. · f0529d91
    Dan McArdle authored
    This CL contains a tentative fix for a crash that was uncovered when we
    enabled the control domain wildcard [1] for the INTEGRITY experiment.
    
    Currently, all INTEGRITY responses get the error OK, regardless of their
    contents. This OK error can overpower the actual errors of A or AAAA
    responses in HostCache::Entry::MergeEntries. As a result, the
    TransportConnectJob assumes that the address results are nonempty, and
    unconditionally dereferences the front of the |AddressList::endpoints_|
    vector [2].
    
    [1]: See net::features::kDnsHttpssvcControlDomainWildcard
    [2]: See net::TransportConnectJob::DoTransportConnect()
    
    Bug: 1136661
    Change-Id: I5d7534c3244cddcf7029c38577d649870ed92bfc
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463598
    Commit-Queue: Dan McArdle <dmcardle@chromium.org>
    Reviewed-by: default avatarEric Orth <ericorth@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#816190}
    f0529d91
host_resolver_manager.cc 140 KB