• Bence Béky's avatar
    [WS] Handle no handshake stream in PerformUpgrade(). · f06fd249
    Bence Béky authored
    The vast majority of recent crash reports point to line 190:
      CHECK(on_handshake_stream_created_has_been_called_);
    
    Next branch cut is around the corner and this is still number one //net
    crasher on M69.  https://crrev.com/c/940463 has been clearly identified
    as the culprit.  Much pondering was still not enough to understand the
    real underlying cause of this crash since the last branch point.  I
    propose to be defensive in WebsocketStream.  While this is not the ideal
    solution, I am not hopeful that we will find anything better any time
    soon.  This approach allows the request to fail safely, while still
    retaining the new WebSocket over HTTP/2 functionality.
    
    Bug: 850183
    Change-Id: I21a7c3919466c4339bebce41ee8ad1342fb9c179
    Reviewed-on: https://chromium-review.googlesource.com/1140916
    Commit-Queue: Bence Béky <bnc@chromium.org>
    Reviewed-by: default avatarAdam Rice <ricea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#576510}
    f06fd249
websocket_stream.cc 18.8 KB