• brettw's avatar
    GN header checker enhancements. · f16d8d8d
    brettw authored
    This makes the check_includes flag work the way one would expect. Previously we
    would only skip include checking if all targets that include a file opt out.
    This was coming up in the Android Java enum generator where a header file was
    being processed by a script (so includes don't matter and there are no deps)
    but that header was also listed as a source in a different target with header
    checking enabled (which is always the case for this example).
    
    Improves error messaging for cross-compiling. Previously if you were
    cross-compiling and forgot a dependency on e.g. base, you'd get a message "you
    must depend on "//base:base" or "//base:base" because it found the files in two
    different toolchain builds of base. This patch prunes such duplicates when
    possible, and turns on toolchain labels if things aren't all in the same
    toolchain.
    
    BUG=
    
    Review URL: https://codereview.chromium.org/946043002
    
    Cr-Commit-Position: refs/heads/master@{#317446}
    f16d8d8d
label.h 4.09 KB