-
Sergey Ulanov authored
Removed test-only methods from CastRunner, WebContentRunner and CastComponent that were previously used in cast_runner_integration_tests. 1. Removed CastRunner and WebContentRunner constructors that take web.Context. Now context is always created in WebContentRunner. 2. Removed test-only methods. 3. Updated TestComponentContext to allow initialization with all services cloned from /svc. The tests now inject a script into the frame in order to test functionality that was previously tested with the test-only methods. Previous attempt to land this CL was reverted due to flake in CastRunnerIntegrationTest.CanRecreateContext test. The test kills WebEngine and was waiting Component termination and assumed that Context and ContextProvider were torn down as well, but they may be destroyed with some delay. To fix this issue this version of the CL adds explicit wait for Context destruction and removes ContextProvider caching from WebContentRunner. Bug: 1062351 Change-Id: I18fa11e85d2194bba1ed3896167a64fac8a51c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143494 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758053}
f1d9f13c