• Daniel Hosseinian's avatar
    Reland "Reload the PDF accessibility tree on layout changes" · f1f9eac7
    Daniel Hosseinian authored
    This is a reland of 2d0cae27.
    
    The original change was reverted because a pre-existing bug in which
    some IPC messages between the plugin and the renderer were dropped due
    to garbage text rendering info attempted to be sent. That bug was fixed
    in crrev.com/833065, so this CL should be safe to reland.
    
    Original change's description:
    > Reload the PDF accessibility tree on layout changes
    >
    > Currently, any layout changes applied to the PDF document (i.e. page
    > rotation or two-up view) after the accessibility tree has loaded does
    > not update the page bounds.
    >
    > Because the accessiblity tree has read-only nodes, the only way to
    > resolve the issue is to reload all the nodes of the tree on each layout
    > change.
    >
    > Note: This CL only fixes page bounds and positions. The bounds of page
    > content such as text or annotations still do not rotate with the rest
    > of the document. Those issues will be fixed in a follow-up.
    >
    > Bug: 1150665
    > Change-Id: I2fbf2cb26f38ee3fed076333c0b224a8ede7947e
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553217
    > Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
    > Reviewed-by: Ankit Kumar 🌪️ <ankk@microsoft.com>
    > Reviewed-by: Raymes Khoury <raymes@chromium.org>
    > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    > Reviewed-by: Tom Sepez <tsepez@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#830918}
    
    Bug: 1150665
    Change-Id: Icf7a1fb3868560dee2f3d6c75dae83c128c4c0f4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570391
    Auto-Submit: Daniel Hosseinian <dhoss@chromium.org>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: default avatarRaymes Khoury <raymes@chromium.org>
    Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#833134}
    f1f9eac7
pdf_accessibility_tree.cc 63.9 KB