• Alex Moshchuk's avatar
    Fix flaky test: ReloadHiddenTabWithCrashedSubframeOutOfView · f1fa51af
    Alex Moshchuk authored
    The suspected cause of flakiness here is that the page used in the
    test scrolls an OOPIF, but doesn't properly wait for layout to finish
    and for visibility/viewport intersection changes to be propagated to
    the corresponding CrossProcessFrameConnector.  This was verified by
    inserting an artificial delay into
    RemoteFrameView::VisibilityChanged().
    
    Fix this by inserting a EvalJsAfterLifecycleUpdate, which will trigger
    requestAnimationFrame and should wait for layout to finish.  This
    usage is similar to a few other uses of EvalJsAfterLifecycleUpdate for
    syncing viewport intersection changes in other tests in this file.
    
    Bug: 1135072
    Change-Id: I49434044a617b1530ce121c24d97aa7071760c9b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503316Reviewed-by: default avatarJames MacLean <wjmaclean@chromium.org>
    Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#821438}
    f1fa51af
site_per_process_browsertest.cc 696 KB