• Antonio Gomes's avatar
    Onion soup content/renderer/image_capture/ · f2bf742a
    Antonio Gomes authored
    In summary this CL:
    
    - Moves content/renderer/image_capture/image_capture_frame_grabber.cc|h
      to t_p/blink/renderer/modules/imagecapture/.
    - Changes t_p/blink/renderer/modules/imagecapture/image_capture.cc to
      instantiate ImageCaptureFrameGrabber directly, instead of calling out
      to RendererBlinkPlatformImpl::CreateImageCaptureFrameGrabber().
    - Removes WebImageCaptureFrameGrabber altogether.
    - Removes the API in [1] creates WebImageCaptureFrameGrabber, as well as
      its overrides.
    
    Additionally, in order to create CrossThreadBind instances that pass
    ScopedWebCallbacks instances, a specialized template of CrossThreadCopier
    was local to [2].
    
    [1] third_party/blink/public/platform/platform.h
    [2] third_party/blink/renderer/modules/imagecapture/image_capture_frame_grabber.cc
    
    Change in [3] were needed to be extended in order to allow the use of
    //media/base and //third_party/libyuv identifiers, similarly to media_capabilities
    and mediastream blink modules.
    
    [3] third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
    
    R=haraken@chromium.org
    CC=​blink-reviews-blink@chromium.org
    
    BUG=787245
    
    Change-Id: I86f75aa6e3483db2d0b7e7243c7f9cc3239f9507
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1576468Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#653466}
    f2bf742a
image_capture.cc 36.9 KB