• Antonio Gomes's avatar
    Replace remaining usages of GaiaCookieManagerServiceFactory::GetInstance in //chrome · f3118cfa
    Antonio Gomes authored
    This CL adds a common factory method named BuildChromeSigninClientWithURLLoader to
    chrome/browser/signin/chrome_signin_client_test_util.cc|h to create a
    ChromeSigninClient instance supplying the test's URLLoaderFactory to it.
    This avoids GCMSFactory::GetInstance to be referenced from various places
    for similar purposes.
    
    In the end, there is no functionality change since GCMS fetches its
    URLLoaderFactory instance from SigninClient when needed.
    
    c/b/signin/gaia_cookie_manager_service_test_util.cc|h is removed.
    
    This includes the following files:
    - chrome/browser/ui/cocoa/test/cocoa_profile_test.mm
    - chrome/browser/extensions/api/identity/identity_apitest.cc
    - chrome/browser/ui/views/frame/test_with_browser_view.cc
    - chrome/browser/metrics/ukm_browsertest.cc
    - chrome/browser/sync/test/integration/secondary_account_helper.cc|h
    - chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc
    - chrome/browser/sync/test/integration/single_cl
    
    TBR=treib@chromium.org (Marc has reviewed //c/b/sync changes in CL_1466606
        that got reverted due to another problem).
    
    BUG=930745
    
    Change-Id: I4887f10f0a66b7c60d21bc7fd97f1b0d8f01a84b
    Reviewed-on: https://chromium-review.googlesource.com/c/1471790Reviewed-by: default avatarDavid Roger <droger@chromium.org>
    Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
    Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#632384}
    f3118cfa
identity_apitest.cc 101 KB