• Jeremie Boulic's avatar
    Update Android storage to Apps and extensions · f3257c1d
    Jeremie Boulic authored
    Before the change, on the storage page, the row "Android storage"
    displayed the size of the android apps. The size of the apps and
    extensions installed from the chrome web store were not reflected
    anywhere on this page.
    
    This row is renamed "Apps and extensions", and displays the size of
    - android apps (including the default ones, which can be deleted if the
    user disables the Play store)
    - apps and extensions installed from the web store, which data is
    located in the Extensions folder of the user's cryptohome, as opposed
    to the system apps/extensions.
    
    The size of web store apps/extensions and android apps are calculated
    separately. The UI is always updated with the sum of both. Bytes
    formatting happen on the C++ side, so summing web store and android
    apps has to happen on the C++ side.
    
    androidRunning_ on the JS side was used to display or hide the
    "Android storage". The "Apps and extensions" row is now always
    visible. androidRunning_ is not needed anymore.
    
    unit_tests --gtest_filter="*StorageHandlerTest.AppsExtensionsSize"
    browser_tests --gtest_filter="*OSSettingsDevicePageTest.StorageTest"
    
    Test: 
    Bug: 1039916
    Change-Id: I4aeffad4a258356ab1cb48834b6bf2cba155f33a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032703Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
    Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#738058}
    f3257c1d
settings_strings.grdp 391 KB