GitLab

GCC: make begin/end/empty methods of StringPiece constexpr to allow them to be called from base::ConsumeDurationNumber

Compilation fails in GCC in base::ConsumeDurationNumber, as it
is a constexpr but it calls methods begin/end/empty in
StringPiece that are not constexpr. This change makes them
constexpr.
../../base/time/time.cc: In function ‘constexpr base::Optional<base::{anonymous}::ParsedDecimal> base::{anonymous}::ConsumeDurationNumber(base::StringPiece&)’:
../../base/time/time.cc:67:63: error: call to non-‘constexpr’ function ‘const value_type* base::BasicStringPiece<STRING_TYPE>::begin() const [with STRING_TYPE = std::__cxx11::basic_string<char>; base::BasicStringPiece<STRING_TYPE>::const_iterator = const char*; base::BasicStringPiece<STRING_TYPE>::value_type = char]’
   67 |   StringPiece::const_iterator orig_start = number_string.begin();
      |                                            ~~~~~~~~~~~~~~~~~~~^~

Bug: 819294, 1049498
Change-Id: If8813ac2651ac444cde7b874a1540c98c256c5b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394159Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#805282}