• Dirk Pranke's avatar
    Reland "Rework generated_script handling in MB." · f37639af
    Dirk Pranke authored
    This reverts commit cd69e8f5.
    
    Reason for revert: re-landing with a fix.
    
    
    Original change's description:
    > Revert "Rework generated_script handling in MB."
    >
    > This reverts commit b05d8793.
    >
    > Reason for revert: Broke ios full_configs bot. See:
    > https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/25885
    >
    > Doesn't look like this change triggered the full_config bots on try.
    >
    > Original change's description:
    > > Rework generated_script handling in MB.
    > >
    > > It turns out the work I did on the "wrapped_*" targets in
    > > gn_isolate_map was somewhat overlapping with the already-existing
    > > iOS work to declare things as "generated_scripts". However, the
    > > generated_scripts did not include test_env.py.
    > >
    > > So, this CL rearranges things so that the generated script will call
    > > test_env.py, and then we can share logic between the generated_script
    > > targets (and every target on iOS and LaCrOS) and use that as the
    > > basis for the rest of the work going forward.
    > >
    > > Bug: 816629
    > > Change-Id: I9d55c3f1587defcb599ddf1df838dd9ed5b6a12c
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357917
    > > Reviewed-by: Erik Staab <estaab@chromium.org>
    > > Commit-Queue: Dirk Pranke <dpranke@google.com>
    > > Cr-Commit-Position: refs/heads/master@{#799171}
    >
    > TBR=dpranke@google.com,estaab@chromium.org,jeffyoon@chromium.org
    >
    > Change-Id: I94597d58417f7aa76320579ca282293e6b643811
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 816629
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364014
    > Reviewed-by: Justin Cohen <justincohen@chromium.org>
    > Commit-Queue: Justin Cohen <justincohen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#799629}
    
    TBR=dpranke@google.com,justincohen@chromium.org,estaab@chromium.org,jeffyoon@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 816629
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs
    Change-Id: I1f481f23ff1f1de991b13f3e5aadf967818c2763
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364696
    Commit-Queue: Dirk Pranke <dpranke@google.com>
    Reviewed-by: default avatarDirk Pranke <dpranke@google.com>
    Cr-Commit-Position: refs/heads/master@{#799880}
    f37639af
ios_test_runner_wrapper.gni 3.91 KB