• Christopher Cameron's avatar
    RemoteMacViews: Update RWHVMac ownership to prepare for accessibility · f397d4b0
    Christopher Cameron authored
    Update the lifetime of RenderWidgetHostNSViewBridgeLocal. Previous to
    this change there were two lifetime modes
    - for in-process instances, RenderWidgetHostNSViewBridgeLocal was
      owned by a scoped_ptr
    - for out-of-process instance, RenderWidgetHostNSViewBridgeLocal would
      be owned by its mojo connection to its parent
    
    Change this so that the out-of-process version creates a
    RenderWidgetHostNSViewBridgeOwner, which is owned by the mojo
    connection, and which owns the RenderWidgetHostNSViewBridgeLocal
    via a scoped_ptr.
    
    Move the former ForwardingClientHelper to be part of
    RenderWidgetHostNSViewBridgeOwner.
    
    Note that this now mirrors structure and behavior in
    views::BridgeFactoryImpl.
    
    Change-Id: I1607df48b8e4ef26feaa180b2b46f49857678f66
    Reviewed-on: https://chromium-review.googlesource.com/c/1347576
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#610483}
    f397d4b0
ns_view_bridge_factory_impl.mm 6.47 KB