GitLab

This reverts commit 9bdd1b02.

Reason for revert:
../../chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc:164: Failure
Expected equality of these values:
  kNumApps + kNumDefaultApps
    Which is: 8
  service->GetNumSyncItemsForTest()
    Which is: 15
This test failure is fixed by a different revert:
https://chromium-review.googlesource.com/c/chromium/src/+/2568995
This CL does not introduce any new app installations on start up
to cause the app count to change.

Original change's description:
> Revert "Fix default web apps not appearing in app list/management/search on Chrome OS"
>
> This reverts commit 090a7e86.
>
> Reason for revert: Suspected it introduced sync_integration_tests failure in SingleClientAppListSyncTestWithVerifier.AppListSomeApps, see https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/10364/overview
>
> Original change's description:
> > Fix default web apps not appearing in app list/management/search on Chrome OS
> >
> > This CL updates Chrome OS default web apps to be deployed to Chrome OS's
> > app surfaces (app list, app search and app management) while maintaining
> > the "do not deploy to OS" logic for non-Chrome OS.
> >
> > This CL upstreams the "do not deploy to OS" logic in
> > GetPreinstalledWebApps() up to
> > ExternalWebAppManager::PostProcessConfigs() where it can apply to all
> > preinstalled web app configs uniformally.
> >
> > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478376&signed_aid=ic4Nc7r-RtFyMKtH3FYXtA==&inline=1
> > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=478378&signed_aid=VMFIAzHdQv62wv7H0Cvz7Q==&inline=1
> >
> > Bug: 1153233
> > Change-Id: Idcbb0d15fc8d3f333d1d59e27b8ff624fe7b1c64
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562625
> > Commit-Queue: Alan Cutter <alancutter@chromium.org>
> > Reviewed-by: Glen Robertson <glenrob@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#832686}
>
> TBR=alancutter@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org
>
> Change-Id: I291b2c2bb25ceb9a244382c4cee7ff190c36a493
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1153233
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566769
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Commit-Queue: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#832739}

TBR=alancutter@chromium.org,olka@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,glenrob@chromium.org

# Not skipping CQ checks because this is a reland.

Bug: 1153233
Change-Id: I9154508d3884fa9296369d8d3976196f19c8d279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569497Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833234}