• Megan Jablonski's avatar
    Fix Translate Tab UI bugs · f45ccec7
    Megan Jablonski authored
    Fix three Tab UI bugs:
    1. The always translate checkbox in the menu was retranslating an
    already translated page when toggled.
    
    2. When reverting a translation from the tab UI, the model's view state
    was not being updated. This meant if a user untranslated the page after
    clicking the always translate button in the menu, then clicked always
    translate again, the page wouldn't translate since the model's state is
    incorrectly "translated" rather than "before translate".
    
    3. The 'always translate' button beneath the tab UI was not being
    updated when the always translate menu item was being clicked.
    
    Additionally this CL removes some unused code that was missed in the
    experiment cleanup.
    
    Bug: 1099571
    Change-Id: I0b3545463acc257ab69cd616bce2e9e833cf2ac4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269751Reviewed-by: default avataranthonyvd <anthonyvd@chromium.org>
    Reviewed-by: default avatarDoug Arnett <dougarnett@chromium.org>
    Commit-Queue: Megan Jablonski <megjablon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#785801}
    f45ccec7
translate_bubble_view.cc 46.2 KB