• Nico Weber's avatar
    Run browser_tests (and viz_browser_tests) on win/asan bot. · f4d9a36a
    Nico Weber authored
    - PlatformAppBrowserTest.PictureInPicture consistently fails with a
      (apparently windows-only) use-after-free on win/asan. That code is new,
      so just revert it (see below), https://crbug.com/873234
    
    - PDFExtensionHitTestTest.MouseLeave flakes fairly often on win/asan, so
      disable the test in that config, https://crbug.com/856169
    
    - SaveType/SavePageOriginalVsSavedComparisonTest.ObjectElementsViaFile/0
      fails fairly consistenly on win/asan (and elsewhere) in
      network_service_browser_tests, so don't enable that suite on the win/asan
      bot just yet (https://crbug.com/840063).
    
    Bug: 869973
    
    Revert "Enable Picture-in-Picture for chrome apps."
    
    This reverts commit e031e566.
    
    Reason for revert: Test has a use-after-free, https://crbug.com/873234
    
    Original change's description:
    > Enable Picture-in-Picture for chrome apps.
    >
    > This CL enables Picture-in-Picture in chrome apps by implementing
    > EnterPictureInPicture and ExitPictureInPicture in AppDelegate.
    >
    > Bug: 863309
    > Change-Id: Ib35e83b03373abe864b3a0674ab1e0b341ce291b
    > Reviewed-on: https://chromium-review.googlesource.com/1156513
    > Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
    > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    > Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#580497}
    
    TBR=beaufort.francois@gmail.com,rdevlin.cronin@chromium.org,jochen@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 863309
    Change-Id: Ib6eda55a3b0889646c43ea3e7bfccdb590cea0b2
    Reviewed-on: https://chromium-review.googlesource.com/1180763
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: default avatarNico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#584347}
    f4d9a36a
chromium.memory.json 217 KB