• Min Qin's avatar
    Reland "All callbacks to notify when InProgressDownloadManager is initialized" · f509280e
    Min Qin authored
    This reverts commit c7496eca.
    
    Reason for revert: <INSERT REASONING HERE>
    
    Original change's description:
    > Revert "All callbacks to notify when InProgressDownloadManager is initialized"
    > 
    > This reverts commit 39c14237.
    > 
    > Reason for revert:
    > Broke many tests on many bots, eg. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/1473
    > 
    > Original change's description:
    > > All callbacks to notify when InProgressDownloadManager is initialized
    > > 
    > > Currently DownloadManagerImpl intializes InProgressDownloadManager.
    > > However, when only ServiceManager is running, DownloadManagerImpl will
    > > not be created.
    > > As a result, some other class will initialize InProgressDownloadManager.
    > > And when chrome fully starts, DownloadManagerImpl needs to know whether
    > > InProgressManager has been initialized.
    > > This CL allows InProgressDownloadManager to take more callbacks to
    > > notify when initialized.
    > > So multiple classes can observe the initialization event.
    > > 
    > > BUG=842245
    > > 
    > > Change-Id: I5881b10db0f93f98262ab1baebc67621c2743fbe
    > > Reviewed-on: https://chromium-review.googlesource.com/1111027
    > > Commit-Queue: Min Qin <qinmin@chromium.org>
    > > Reviewed-by: David Trainor <dtrainor@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#569849}
    > 
    > TBR=dtrainor@chromium.org,qinmin@chromium.org
    > 
    > Change-Id: Ic2e8b09dc8aca3680c7a5939fdfb545e0dfec82a
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 842245
    > Reviewed-on: https://chromium-review.googlesource.com/1112977
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Commit-Queue: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#569879}
    
    TBR=thakis@chromium.org,dtrainor@chromium.org,qinmin@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 842245
    Change-Id: I9a2d1e2215f755785190400e554408f3bf2e7de5
    Reviewed-on: https://chromium-review.googlesource.com/1113839
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Reviewed-by: default avatarMin Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#570140}
    f509280e
in_progress_download_manager.cc 20.3 KB