• Eric Willigers's avatar
    Desktop PWAs: ShelfAppBrowserTest enabled for BMO · f56ca6b5
    Eric Willigers authored
    GetAppIdForTab() for BMO now returns nullopt if a web app is configured
    to open in a window, and a browser tab has a URL in the app's scope
    open. This matches existing behavior for bookmark apps.
    
    ShelfWebAppBrowserTest.WindowedHostedAndWebApps/WebApps was previously
    failing.
    (The test installs a web app configured to open in a tab by default.
    It navigates to launch the app URL in a tab and asserts the shelf
    status indicates the app is closed. This assert previously failed
    for BMO. The test then calls ActivateAppAndFlushMojoCallsForAppService
    and asserts there is an extra browser and the app is running. That
    assert also previously failed for BMO.)
    
    Bug: 1054116
    Change-Id: I2a5cbb64b193874442deb093ecbbb1f2c7d6ead3
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428293Reviewed-by: default avatarAlan Cutter <alancutter@chromium.org>
    Reviewed-by: default avatarNancy Wang <nancylingwang@chromium.org>
    Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#810486}
    f56ca6b5
launcher_controller_helper.cc 12.7 KB