• digit@chromium.org's avatar
    Add CLIENT_CERT_TYPE_DSS_SIGN to net::SSLClientCertType · f5cae0f9
    digit@chromium.org authored
    This patch adds a new value to the net::SSLClientCertType that matches
    DSA-based client certificates. This will be used by Android's client
    certificate support code.
    
    For an example, see https://chromiumcodereview.appspot.com/12220104/
    
    More specifically:
    
    - It modifies <net/base/ssl_client_cert_type.h> to add the new
      enum value.
    
    - It adds a corresponding non-translatable string ID to
      chrome/app/generated_resources.grd, and ensures that the
      ClientCertTypeToString() function in cookies_tree_model_util.cc
      returns it appropriately.
    
    - It adds SpdyCredentialBuilderTest.MAYBE_FailedWithDSACert
      unit test, similar to the MAYBE_FailedWithRSACert. This is
      based on the assumption that SPDY uses ECDSA certificates
      exclusively (no code supporting RSA-based ones was found
      under net/spdy).
    
    Note that server-bound certificate unit tests have not been
    modified (some of them handle both RSA and ECDSA certificates),
    given that none of the production support code for this feature
    seems to care about the certificate type, and that DSA-based
    certificates are extremely rare in practice, and disappearing.
    
    BUG=165668
    
    
    Review URL: https://chromiumcodereview.appspot.com/12221136
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182119 0039d316-1c4b-4281-b951-d872f2087c98
    f5cae0f9
generated_resources.grd 971 KB